Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate the verification controller ASAP #3893

Merged

Conversation

jmartinesp
Copy link
Member

Content

What the title says.

Motivation and context

This is needed to get incoming verification requests.

Tests

  • Start incoming verification request from another device.
  • If you receive it in the one running this build, it's working.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

This is needed to get incoming verification requests
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Nov 19, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner November 19, 2024 10:53
@jmartinesp jmartinesp requested review from ganfra and removed request for a team November 19, 2024 10:53
@jmartinesp jmartinesp changed the title Instantiate the verification controller when possible Instantiate the verification controller ASAP Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vtBAXp

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 19, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) November 19, 2024 11:13
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 19, 2024
Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (b06699e) to head (0e11cd0).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3893   +/-   ##
========================================
  Coverage    82.90%   82.90%           
========================================
  Files         1785     1785           
  Lines        45111    45111           
  Branches      5328     5328           
========================================
  Hits         37398    37398           
  Misses        5844     5844           
  Partials      1869     1869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 19, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 19, 2024
@jmartinesp jmartinesp merged commit 6bce3d5 into develop Nov 19, 2024
27 of 28 checks passed
@jmartinesp jmartinesp deleted the fix/register-verification-controller-when-possible branch November 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants