Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min size for hidden media #3906

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Min size for hidden media #3906

merged 4 commits into from
Nov 21, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 20, 2024

Content

First commit: ensure that media cannot be opened full screen when it is hidden. It has to be revealed first.
Second commit: Ensure that when a media is hidden, the "Show" button is always visible in case the aspect ratio is very low or very high.

Motivation and context

Closes #3865

Screenshots / GIFs

Before After After, media shown
image image image

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 20, 2024 21:47
@bmarty bmarty requested review from ganfra and removed request for a team November 20, 2024 21:47
Copy link
Contributor

github-actions bot commented Nov 20, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pKWVso

@bmarty bmarty force-pushed the feature/bma/minSizeForHiddenMedia branch from ad8e8ee to c7e52a8 Compare November 21, 2024 08:06
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 21, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 21, 2024
@bmarty bmarty added the PR-Bugfix For bug fix label Nov 21, 2024
Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (7edfefe) to head (aa1948a).
Report is 34 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3906      +/-   ##
===========================================
+ Coverage    82.91%   82.94%   +0.03%     
===========================================
  Files         1785     1787       +2     
  Lines        45164    45178      +14     
  Branches      5332     5335       +3     
===========================================
+ Hits         37446    37474      +28     
+ Misses        5847     5827      -20     
- Partials      1871     1877       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bmarty bmarty merged commit 81d2e0d into develop Nov 21, 2024
25 checks passed
@bmarty bmarty deleted the feature/bma/minSizeForHiddenMedia branch November 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show" button for image previews is too small or invisible on images with a short height
3 participants