-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Min size for hidden media #3906
Conversation
… content has first been revealed in the timeline.
…he "Show" button is always visible.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
ad8e8ee
to
c7e52a8
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3906 +/- ##
===========================================
+ Coverage 82.91% 82.94% +0.03%
===========================================
Files 1785 1787 +2
Lines 45164 45178 +14
Branches 5332 5335 +3
===========================================
+ Hits 37446 37474 +28
+ Misses 5847 5827 -20
- Partials 1871 1877 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Content
First commit: ensure that media cannot be opened full screen when it is hidden. It has to be revealed first.
Second commit: Ensure that when a media is hidden, the "Show" button is always visible in case the aspect ratio is very low or very high.
Motivation and context
Closes #3865
Screenshots / GIFs
Tests
Tested devices
Checklist