-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix element call crash when resuming from notification #3926
Conversation
// If presenter is not created at this point, it means we have no call to display, the Activity is finishing, so return early | ||
if (!::presenter.isInitialized) { | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly necessary, but should prevent future crash...
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3926 +/- ##
===========================================
- Coverage 83.00% 82.99% -0.01%
===========================================
Files 1788 1788
Lines 45210 45213 +3
Branches 5335 5337 +2
===========================================
Hits 37526 37526
- Misses 5810 5813 +3
Partials 1874 1874 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Content
Ensure that when the call is resume when clicking on the notification, the app does not crash.
Seems that this is a regression from #3833.
Motivation and context
Fix #3905
Screenshots / GIFs
Tests
Tested devices
Checklist