Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long click not working on pinned events timeline #3940

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

jmartinesp
Copy link
Member

Content

What the title says.

Motivation and context

#3879 made long click not work on the pinned events timeline by mistake.

Tests

  • Open the pinned events timeline on a room with pinned events (pin some events first if needed).
  • Long click on an item, check the modal bottom sheet is displayed as expected.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Nov 25, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner November 25, 2024 11:48
@jmartinesp jmartinesp requested review from bmarty and removed request for a team November 25, 2024 11:48
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aChFLE

Copy link

sonarcloud bot commented Nov 25, 2024

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (e347294) to head (05ed0a5).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3940   +/-   ##
========================================
  Coverage    82.96%   82.96%           
========================================
  Files         1789     1789           
  Lines        45234    45235    +1     
  Branches      5341     5341           
========================================
+ Hits         37529    37530    +1     
  Misses        5830     5830           
  Partials      1875     1875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix!

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 25, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) November 25, 2024 12:28
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 25, 2024
@jmartinesp jmartinesp merged commit a080444 into develop Nov 25, 2024
33 checks passed
@jmartinesp jmartinesp deleted the fix/long-click-on-pinned-event-timeline branch November 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants