-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework on media module #3967
Rework on media module #3967
Conversation
import io.element.android.libraries.textcomposer.model.TextEditorState | ||
import io.element.android.libraries.textcomposer.model.aTextEditorStateMarkdown | ||
|
||
open class AttachmentsPreviewStateProvider : PreviewParameterProvider<AttachmentsPreviewState> { | ||
override val values: Sequence<AttachmentsPreviewState> | ||
get() = sequenceOf( | ||
anAttachmentsPreviewState(), | ||
anAttachmentsPreviewState(mediaInfo = aVideoMediaInfo()), | ||
anAttachmentsPreviewState(mediaInfo = anAudioMediaInfo()), | ||
anAttachmentsPreviewState(mediaInfo = anApkMediaInfo()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the content is not the real content anymore, there is no need to have multiple identical previews.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
9cf4433
to
d37ec23
Compare
Remove obsolete items Reorder items.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3967 +/- ##
===========================================
+ Coverage 83.01% 83.06% +0.05%
===========================================
Files 1795 1804 +9
Lines 45549 45587 +38
Branches 5370 5373 +3
===========================================
+ Hits 37812 37869 +57
+ Misses 5857 5832 -25
- Partials 1880 1886 +6 ☔ View full report in Codecov by Sentry. |
|
Content
Move code from the
api
module to theimpl
module and rearrange package organisation.Also split code between multiple files.
Motivation and context
Improve build time and prepare work for media browser
Screenshots / GIFs
No change expected.
Tests
Tested devices
Checklist