-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning when adding a caption. #3977
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
cb4b603
to
94ebac7
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3977 +/- ##
===========================================
+ Coverage 83.03% 83.10% +0.07%
===========================================
Files 1796 1806 +10
Lines 45600 45703 +103
Branches 5375 5381 +6
===========================================
+ Hits 37864 37983 +119
+ Misses 5855 5832 -23
- Partials 1881 1888 +7 ☔ View full report in Codecov by Sentry. |
Content
Add a warning picto (under an enabled FF) to let the user know that caption may not be visible for other users.
I prefer to keep the other FF (which enable or disable caption creation) but it is now enabled by default.
Motivation and context
Android friend of element-hq/element-x-ios#3574
Figma: https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?node-id=1990-23220
Screenshots / GIFs
Caption.warning.mp4
Tests
Tested devices
Checklist