Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when adding a caption. #3977

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 2, 2024

Content

Add a warning picto (under an enabled FF) to let the user know that caption may not be visible for other users.
I prefer to keep the other FF (which enable or disable caption creation) but it is now enabled by default.

Motivation and context

Android friend of element-hq/element-x-ios#3574
Figma: https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?node-id=1990-23220

Screenshots / GIFs

Caption.warning.mp4

Tests

  • Send an image and during the preview, see the new picto in the composer, which can be clicked

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner December 2, 2024 13:45
@bmarty bmarty requested review from ganfra and removed request for a team December 2, 2024 13:45
@bmarty bmarty added the PR-Misc For other changes label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tiHEQ8

@bmarty bmarty added Z-NextRelease For issues and PRs which should be included in the NextRelease. Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Dec 2, 2024
@bmarty bmarty force-pushed the feature/bma/captionWarning branch from cb4b603 to 94ebac7 Compare December 2, 2024 14:54
@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. and removed Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Dec 2, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 2, 2024
Copy link

sonarcloud bot commented Dec 2, 2024

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 95.87629% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.10%. Comparing base (b73884c) to head (c926697).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...ent/android/libraries/textcomposer/TextComposer.kt 95.34% 1 Missing and 1 partial ⚠️
...ibraries/textcomposer/CaptionWarningBottomSheet.kt 96.29% 1 Missing ⚠️
...ibraries/textcomposer/model/MessageComposerMode.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3977      +/-   ##
===========================================
+ Coverage    83.03%   83.10%   +0.07%     
===========================================
  Files         1796     1806      +10     
  Lines        45600    45703     +103     
  Branches      5375     5381       +6     
===========================================
+ Hits         37864    37983     +119     
+ Misses        5855     5832      -23     
- Partials      1881     1888       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit e1be8c6 into develop Dec 2, 2024
26 checks passed
@bmarty bmarty deleted the feature/bma/captionWarning branch December 2, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants