Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase ringing timeout from 15 seconds to 90 seconds #3991

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

fkwp
Copy link
Contributor

@fkwp fkwp commented Dec 4, 2024

Bugs around ringing have been resolved and it's considered generally reliable now so it's a good time to increase the timeout.

@fkwp fkwp requested a review from a team as a code owner December 4, 2024 09:12
@fkwp fkwp requested review from ganfra and removed request for a team December 4, 2024 09:12
@CLAassistant
Copy link

CLAassistant commented Dec 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@ganfra ganfra enabled auto-merge December 4, 2024 10:06
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 4, 2024
@ganfra ganfra disabled auto-merge December 4, 2024 13:00
@ganfra ganfra merged commit 9573577 into element-hq:develop Dec 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run-Maestro Starts a Maestro Cloud session to run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants