Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composer) : use HideKeyboardWhenDisposed only in MessagesView #3993

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 4, 2024

Content

What the title says.

Motivation and context

TextComposer is disposed each time the size changes for some reason, so the keyboard was dismissed when typing.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease. labels Dec 4, 2024
@ganfra ganfra marked this pull request as ready for review December 4, 2024 10:34
@ganfra ganfra requested a review from a team as a code owner December 4, 2024 10:34
@ganfra ganfra requested review from bmarty and removed request for a team December 4, 2024 10:34
Copy link

sonarcloud bot commented Dec 4, 2024

Copy link
Contributor

github-actions bot commented Dec 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oL5hzS

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (01cd76a) to head (a81392d).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3993   +/-   ##
========================================
  Coverage    83.09%   83.09%           
========================================
  Files         1808     1808           
  Lines        45887    45887           
  Branches      5394     5395    +1     
========================================
  Hits         38131    38131           
  Misses        5862     5862           
  Partials      1894     1894           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 4, 2024
@ganfra ganfra enabled auto-merge December 4, 2024 13:40
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 4, 2024
@ganfra ganfra merged commit f3ee89d into develop Dec 4, 2024
37 checks passed
@ganfra ganfra deleted the feature/fga/fix_keyboard_dismiss branch December 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants