Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry send popup shows up over room list on ipad #2808

Closed
marwing opened this issue May 7, 2024 · 0 comments
Closed

retry send popup shows up over room list on ipad #2808

marwing opened this issue May 7, 2024 · 0 comments
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@marwing
Copy link

marwing commented May 7, 2024

Steps to reproduce

  1. force a failed message by sending in a room without a network connection
  2. wait for the app to say it failed
  3. tap on the message to resend
  4. have to move your hand across the screen because the popup shows up over the room list

Outcome

What did you expect?

the popup to be at/near the relevant message, especially since it has an arrow pointing at something

What happened instead?

popup looses visual connection to message
IMG_0189

Your phone model

iPad Pro (11-inch)

Operating system version

iPadOS 17.4.1

Application version

1.6.4 (104)

Homeserver

Synapse 1.106.0 / Proxy 0.99.16

Will you send logs?

No
@stefanceriu stefanceriu added A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 9, 2024
stefanceriu added a commit that referenced this issue May 9, 2024
@stefanceriu
Fixes #2808 - Switch the message sending failure options from a dialo…
c1495aa 
…g to an alert

- this prevents it from showing up as a popup on the room list on an iPad
- it used to be set on the timeline and not on the timeline item because of our use of a UITableView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @marwing