Include app name in default session display name

[Johennes]

This ports element-hq/element-ios#6828 over to ElementX. Please see the Element iOS PR for the reasoning.

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 90cbf9a

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wZJwbS

[Johennes]

Hm, testVerificationCancellation keeps failing but it also fails on develop so I don't think this is related to my changes.

[pixlwave]

LGTM, although we're currently using cfBundleName everywhere else and the cfBundleDisplayName has the same value, so I'm wondering if it adds anything using that?

[Johennes]

I'm not sure to be honest. I just copied this over from Element-iOS. Happy to change to cfBundleName if that seems more appropriate.

[Johennes]

Ah, reading up in the docs it seems there is a slight difference:

CFBundleName: A user-visible short name for the bundle.

This name can contain up to 15 characters. The system may display it to users if CFBundleDisplayName isn't set.

CFBundleDisplayName: The user-visible name for the bundle, used by Siri and visible on the iOS Home screen.

Use this key if you want a product name that's longer than CFBundleName.

So I think CFBundleDisplayName might be better to use actually because it allows for longer app names.

[pixlwave]

Yep you're right, that makes sense to me. Would you mind updating any other uses of ElementInfoPlist.cfBundleName to be ElementInfoPlist.cfBundleDisplayName for consistency?

[Johennes]

Ah, good idea, yes. Have replaced all the usages now.

[pixlwave]

Thanks 🙏

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication