Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to disable hidden profiles for ignored users. #2892

Merged
merged 2 commits into from
May 31, 2024

Conversation

pixlwave
Copy link
Member

We won't use the flag, it is for forks.

@pixlwave pixlwave requested a review from a team as a code owner May 30, 2024 16:26
@pixlwave pixlwave requested review from stefanceriu and removed request for a team May 30, 2024 16:26
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 701a232

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 84.72222% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 78.08%. Comparing base (a4c9135) to head (701a232).

Files Patch % Lines
...ockedUsersScreen/BlockedUsersScreenViewModel.swift 85.29% 5 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 3 Missing ⚠️
...kedUsersScreen/BlockedUsersScreenCoordinator.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2892      +/-   ##
===========================================
+ Coverage    78.07%   78.08%   +0.01%     
===========================================
  Files          685      685              
  Lines        53258    53305      +47     
===========================================
+ Hits         41581    41624      +43     
- Misses       11677    11681       +4     
Flag Coverage Δ
unittests 68.64% <84.72%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit 6deedb5 into develop May 31, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/ignored-user-profiles branch May 31, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants