-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating multiple clients if the NSE is invoked more than once … #2944
Conversation
Generated by 🚫 Danger Swift against 29b9e36 |
…on the same process
0b3a3ee
to
71a65c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2944 +/- ##
===========================================
+ Coverage 78.31% 78.34% +0.02%
===========================================
Files 691 691
Lines 54028 54146 +118
===========================================
+ Hits 42313 42420 +107
- Misses 11715 11726 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
985b51a
to
40f16d2
Compare
40f16d2
to
29b9e36
Compare
Quality Gate passedIssues Measures |
…on the same process
This came out of a discussion with @bnjbvr from which I quote: