Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Danger fixes #3304

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Various Danger fixes #3304

merged 2 commits into from
Sep 18, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Sep 18, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 18, 2024 15:44
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team September 18, 2024 15:44
@stefanceriu stefanceriu changed the title Various danger fixes Various Danger fixes Sep 18, 2024
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6824069

Copy link

sonarcloud bot commented Sep 18, 2024

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (ac27951) to head (6824069).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3304      +/-   ##
===========================================
- Coverage    77.26%   77.26%   -0.01%     
===========================================
  Files          735      735              
  Lines        59386    59499     +113     
===========================================
+ Hits         45887    45973      +86     
- Misses       13499    13526      +27     
Flag Coverage Δ
unittests 68.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 5d678ab into develop Sep 18, 2024
13 checks passed
@pixlwave pixlwave deleted the stefan/dangerFix branch September 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants