Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of random tweaks. #3317

Merged
merged 8 commits into from
Sep 23, 2024
Merged

A bunch of random tweaks. #3317

merged 8 commits into from
Sep 23, 2024

Conversation

pixlwave
Copy link
Member

Fix some warnings etc, easiest to review commit by commit for context of each change.

@pixlwave pixlwave added the pr-misc for other changes label Sep 23, 2024
@pixlwave pixlwave requested a review from a team as a code owner September 23, 2024 10:19
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 23, 2024 10:19
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against bb704be

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.44%. Comparing base (d48214a) to head (bb704be).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...esolveVerifiedUserSendFailureScreenViewModel.swift 15.38% 11 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 2 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 2 Missing ⚠️
...olveVerifiedUserSendFailureScreenCoordinator.swift 0.00% 2 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 0.00% 2 Missing ⚠️
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3317      +/-   ##
===========================================
- Coverage    77.45%   77.44%   -0.02%     
===========================================
  Files          735      735              
  Lines        59475    59481       +6     
===========================================
- Hits         46068    46066       -2     
- Misses       13407    13415       +8     
Flag Coverage Δ
unittests 68.68% <37.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit e4736b1 into develop Sep 23, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/misc branch September 23, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants