Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing and integration test tweaks #3336

Merged
merged 12 commits into from
Sep 27, 2024
Merged

Tracing and integration test tweaks #3336

merged 12 commits into from
Sep 27, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner September 26, 2024 15:11
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team September 26, 2024 15:11
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

@stefanceriu stefanceriu added the pr-misc for other changes label Sep 26, 2024
pixlwave
pixlwave approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ElementX/Sources/Other/Logging/TracingConfiguration.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/Logging/TracingConfiguration.swift Show resolved Hide resolved
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift Outdated Show resolved Hide resolved
@stefanceriu
Disable image and document picker integration tests as they randomly …
1f1d302 
…fail to load and are flakey.
@stefanceriu
Delete any pre-existing log files
802c61d
@stefanceriu
Various tracing tweaks and fixes:
39954a3 
- delete the custom tracing log levels as we can't control their ouput
- implement comparable on them
- change default levels only if the new chosen level increases their verbosity
@stefanceriu
Make Github actions like the private message check
e9dae49
@stefanceriu
Address PR comments
1d2234f
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 5c4b31b

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit 9d23dec into develop Sep 27, 2024
6 of 7 checks passed
@stefanceriu stefanceriu deleted the stefan/integrationShenanigans branch September 27, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave