-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the RustSDK to v1.0.53: adopt latest record based timeline item APIs #3356
Conversation
Generated by 🚫 Danger Swift against 4194f06 |
❌ 3 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 2 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👏
ElementX/Sources/Services/Room/RoomSummary/RoomEventStringBuilder.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemViewState.swift
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
eventOrTransactionId
which we now use within the TimelineItemIdentifiertimelineID
has been renamed touniqueID
to match the SDK side and avoid confusion