Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the RustSDK to v1.0.53: adopt latest record based timeline item APIs #3356

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

stefanceriu
Copy link
Member

  • the TimelineItems and their content are now records, which in turns means a lot of changes had to happen.
  • a new way to identity items was also introduced in the form of eventOrTransactionId which we now use within the TimelineItemIdentifier
  • the timelineID has been renamed to uniqueID to match the SDK side and avoid confusion
  • various other tweaks and fixes

@stefanceriu stefanceriu requested a review from a team as a code owner October 1, 2024 13:07
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team October 1, 2024 13:07
Copy link

github-actions bot commented Oct 1, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4194f06

@stefanceriu stefanceriu added the pr-misc for other changes label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
838 3 835 0
View the top 1 failed tests by shortest run time
RoomChangePermissionsScreenViewModelTests testSave()
Stack Traces | 0.168s run time
XCTAssertTrue failed (.../UnitTests/Sources/RoomChangePermissionsScreenViewModelTests.swift:64)
View the full list of 2 ❄️ flaky tests
PreviewTests test_serverSelection()

Flake rate in main: 39.62% (Passed 32 times, Failed 21 times)

Stack Traces | 2.5s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8937988 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 25.88% (Passed 63 times, Failed 22 times)

Stack Traces | 13.1s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏

Copy link

sonarcloud bot commented Oct 1, 2024

@stefanceriu stefanceriu enabled auto-merge (squash) October 1, 2024 15:02
@stefanceriu stefanceriu merged commit c79dbe8 into develop Oct 1, 2024
7 checks passed
@stefanceriu stefanceriu deleted the stefan/timelineItemRecords branch October 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants