Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how file captions are rendered #3554

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Update how file captions are rendered #3554

merged 4 commits into from
Nov 26, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 25, 2024

Updates the design to show both the filename and the caption (and use the design from Compound which we hadn't adopted)

File Audio File
test_fileRoomTimelineView-iPhone-16-en-GB 1 test_audioRoomTimelineView-iPhone-16-en-GB 1

@pixlwave pixlwave requested a review from a team as a code owner November 25, 2024 15:07
@pixlwave pixlwave requested review from stefanceriu and removed request for a team November 25, 2024 15:07
Copy link

github-actions bot commented Nov 25, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 46113a3

@pixlwave pixlwave added the pr-change for updates to an existing feature label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 98.41270% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (ba8edc3) to head (46113a3).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3554      +/-   ##
===========================================
- Coverage    78.64%   78.62%   -0.03%     
===========================================
  Files          757      757              
  Lines        63582    63637      +55     
===========================================
+ Hits         50005    50033      +28     
- Misses       13577    13604      +27     
Flag Coverage Δ
unittests 69.67% <98.41%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 26, 2024

@pixlwave pixlwave merged commit 03aaf84 into develop Nov 26, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/file-captions branch November 26, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants