Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of the SQLite-based crypto store #10

Merged
merged 12 commits into from
Apr 21, 2023
Merged

Allow usage of the SQLite-based crypto store #10

merged 12 commits into from
Apr 21, 2023

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Apr 14, 2023 •
edited
Loading

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

@turt2live
Fix key query and claim APIs to support async functionality (turt2liv…
1c203f8 
…e#314)

* Fix key query and claim APIs to support async functionality

* fix copy/paste fail
@AndrewFerr AndrewFerr requested a review from a team as a code owner April 14, 2023 14:24
@AndrewFerr AndrewFerr mentioned this pull request Apr 14, 2023
Open
@AndrewFerr AndrewFerr self-assigned this Apr 14, 2023
@AndrewFerr AndrewFerr mentioned this pull request Apr 14, 2023
Merged
turt2live and others added 6 commits April 16, 2023 21:04
@turt2live
Better interface
ee0cf33
@turt2live
v0.6.5
b902df5
@turt2live
Reset version back to "develop" for jsdoc, for now
d4612db
@AndrewFerr
Allow usage of the SQLite-based crypto store
3bd23c4 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Add types for lowdb
c73cacf 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Update tests
bce5d60 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr AndrewFerr changed the title Sql crypto store Allow usage of the SQLite-based crypto store Apr 17, 2023
@AndrewFerr
Update examples
00a0b27 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Fix lint rules for new the imports in examples
dc8202a 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Test the SQLite crypto store
4c07639 
Run all tests with both the Sled and SQLite store types

Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Fix lint rules
3f24fb5 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Add missing semicolon
a983376 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
Half-Shot
Half-Shot approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nit but I can take it or leave it.

src/storage/RustSdkCryptoStorageProvider.ts Show resolved Hide resolved
@AndrewFerr
Copy link
Member Author

The latest set of commits just pulls in the updates to tests that I put into the upstream PR, whose CI informs me that they pass 🙂

@AndrewFerr AndrewFerr merged commit 50460ae into element-main Apr 21, 2023
@AndrewFerr AndrewFerr deleted the sql-crypto-store branch June 13, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees

@AndrewFerr AndrewFerr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewFerr @Half-Shot @turt2live