Remove check of matching claimed and detected MIME type #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not necessary since we already check allowed MIME types against the detected type and not the claimed one. It leads to quite a bunch of false positives since a lot of clients have trouble properly detecting the type.
devonh
approved these changes
Jul 24, 2024
devonh
reviewed
Jul 24, 2024
| is always 'application/octet-stream') | ||
| * files with this MIME type are allowed (if an allow list is provided in the | ||
| configuration) | ||
| def _check_mimetype(self,media_content: bytes) -> None: |
There was a problem hiding this comment.
Suggested change
| def _check_mimetype(self,media_content: bytes) -> None: | |
| def _check_mimetype(self, media_content: bytes) -> None: |
There was a problem hiding this comment.
This should fix the linter error.
devonh
requested changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems not necessary since we already check allowed MIME types against the detected type and not the claimed one.
It leads to quite a bunch of false positives since a lot of clients have trouble properly detecting the type.