Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Refactor CreateCrossSigningDialog #131

Closed
wants to merge 7 commits into from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Oct 8, 2024

  • Converts CreateCrossSigningDialog to a functional component
  • Pulls logic out to its own class
  • Updates usage of deprecated cross signing bootstrap method on client to be on the crypto object and updates test to match

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@dbkr dbkr added the T-Task Tasks for the team like planning label Oct 8, 2024
Because we don't have the context wrapper for that screen (it probably
ought to but that can wait for a refactor of the matrixchat screens).
and remove other crypto mock that's now unnecessary
@t3chguy
Copy link
Member

t3chguy commented Oct 16, 2024

We have made the decision to merge matrix-react-sdk into https://github.com/element-hq/element-web - if you are still interested in this contribution please move it to that repository. Closing so it does not remain as a zombie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants