This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Fix bell icons on room list hover being black squares #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EchoStore wasn't being set up and therefore missed the client being injected. Patch from @t3chguy.
t3chguy
approved these changes
Oct 9, 2024
dbkr
added a commit
that referenced
this pull request
Oct 10, 2024
This seems to be causing a lot of weirdness, presumably because there's another missing thing like in #135, but I don't know what it might be and it feels like it might take a while to find. Backing these changes out to fix develop while we sort it out. Fixes element-hq/element-web#28179
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
This seems to be causing a lot of weirdness, presumably because there's another missing thing like in #135, but I don't know what it might be and it feels like it might take a while to find. Backing these changes out to fix develop while we sort it out. Fixes element-hq/element-web#28179
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EchoStore wasn't being set up and therefore missed the client being injected.
Patch from @t3chguy.
Fixes element-hq/element-web#28169
Regressed by #124
Also fixed the MatrixClientPeg test to actually just test the clientpeg class rather than spinning up a real client and trying to start it, because otherwise it was failing in weird ways.
Checklist
public/exportedsymbols have accurate TSDoc documentation.