This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Fix flaky crypto playwright tests #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a couple of flaky tests which were not waiting for the /sync to complete after joining a room.
This bit can take a while as well.
MidhunSureshR
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Not the assigned reviewer but this PR is useful for merging #84
Co-authored-by: R Midhun Suresh <hi@midhun.dev>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
richvdh
force-pushed
the
rav/fix_flaky_shields_test
branch
from
d72a509
to
01dfc7b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit comments for details.
Fixes element-hq/element-web#28061