This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Add support for rendering media captions #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
dbkr
reviewed
Oct 2, 2024
|
Added screenshot |
|
and what a screenshot it is. Requested design review, with promise of cats. |
dbkr
approved these changes
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Not sure why that test only failed in the merge queue 🤔 I guess I'll add another mock there |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This works great with modern layout, but is quite broken with bubble layout. Some captions are not visible with image bubbles 🤔 |
|
🙀 |
This was referenced Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-js-sdk#4403
Preview:
When hovering over image