Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

iOS and Android missing support for widget URL templates / interpolation #125

Closed
rxl881 opened this issue Dec 8, 2017 · 3 comments
Closed
Assignees

Comments

@rxl881
Copy link

rxl881 commented Dec 8, 2017

The mobile apps do not currently support widget URL interpolation. This is required for widgets such as tradingview (currently live on /develop and /app).

The main intent of this feature is for variables, either from the widget data object, or from the current user / room props. to be substituted in to the widget URL and passed down to the widget for rendering.

An example URL template looks like this (in JS):

const widgetBaseUrl = '/tradingView.html?exchangePair=$pair&dateRange=$dateRange';

The widget data object would be set with something like this:

data: {
    pair: pair,
    dateRange: dateRange,
},

And the riot-web code for URL template interpolation can be found here -
https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/rooms/AppsDrawer.js#L107-L151

Can you please look at adding this feature to the mobile apps asap. Please let me know if you need any help or further information.

@rxl881
Copy link
Author

rxl881 commented Dec 13, 2017

Thanks very much for adding this @manuroe.

@ylecollen is this on your "radar" for android too?

Thanks.

@ylecollen
Copy link

ylecollen commented Dec 14, 2017

@rxl881
it is fixed on android too.
element-hq/riot-android@08f5948

@rxl881
Copy link
Author

rxl881 commented Dec 14, 2017

Great! Thanks Yannick 👍

manuroe added a commit to element-hq/element-ios that referenced this issue Dec 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants