Skip to content

Commit

Permalink
Remove unnecessary call to resume producing in fake channel (#17449)
Browse files Browse the repository at this point in the history
This fell out of the authenticated media work - this bit of code masked
a bug but does not break anything when removed, so probably should be
removed.
  • Loading branch information
H-Shay committed Jul 16, 2024
1 parent df11af1 commit 899d33f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions changelog.d/17449.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unnecessary call to resume producing in fake channel.
4 changes: 0 additions & 4 deletions tests/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,6 @@ def await_result(self, timeout_ms: int = 1000) -> None:
self._reactor.run()

while not self.is_finished():
# If there's a producer, tell it to resume producing so we get content
if self._producer:
self._producer.resumeProducing()

if self._reactor.seconds() > end_time:
raise TimedOutException("Timed out waiting for request to finish.")

Expand Down

0 comments on commit 899d33f

Please sign in to comment.