-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fully-qualified PersistedEventPosition
when returning RoomsForUser
#17265
Merged
Commits on Jun 3, 2024
-
Use fully-qualified
PersistedEventPosition
when returning membershi……p for user Spawning from #17187
Configuration menu - View commit details
-
Copy full SHA for 271a196 - Browse repository at this point
Copy the full SHA 271a196View commit details -
Fix circular imports when running specific tests
Before: ``` $ SYNAPSE_POSTGRES=1 SYNAPSE_POSTGRES_USER=postgres SYNAPSE_TEST_LOG_LEVEL=INFO poetry run trial tests.replication.storage.test_events [...] Traceback (most recent call last): File "pypoetry/virtualenvs/matrix-synapse-xCtC9ulO-py3.12/lib/python3.12/site-packages/twisted/trial/runner.py", line 711, in loadByName return self.suiteFactory([self.findByName(name, recurse=recurse)]) File "pypoetry/virtualenvs/matrix-synapse-xCtC9ulO-py3.12/lib/python3.12/site-packages/twisted/trial/runner.py", line 474, in findByName obj = reflect.namedModule(searchName) File "pypoetry/virtualenvs/matrix-synapse-xCtC9ulO-py3.12/lib/python3.12/site-packages/twisted/python/reflect.py", line 156, in namedModule topLevel = __import__(name) File "synapse/tests/replication/storage/test_events.py", line 33, in <module> from synapse.handlers.room import RoomEventSource File "synapse/synapse/handlers/room.py", line 74, in <module> from synapse.rest.admin._base import assert_user_is_admin File "synapse/synapse/rest/__init__.py", line 24, in <module> from synapse.rest import admin File "synapse/synapse/rest/admin/__init__.py", line 41, in <module> from synapse.handlers.pagination import PURGE_HISTORY_ACTION_NAME File "synapse/synapse/handlers/pagination.py", line 30, in <module> from synapse.handlers.room import ShutdownRoomParams, ShutdownRoomResponse builtins.ImportError: cannot import name 'ShutdownRoomParams' from partially initialized module 'synapse.handlers.room' (most likely due to a circular import) (synapse/synapse/handlers/room.py) ```
Configuration menu - View commit details
-
Copy full SHA for 4155e18 - Browse repository at this point
Copy the full SHA 4155e18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 939695d - Browse repository at this point
Copy the full SHA 939695dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73c20d9 - Browse repository at this point
Copy the full SHA 73c20d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b41f41 - Browse repository at this point
Copy the full SHA 7b41f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09638ac - Browse repository at this point
Copy the full SHA 09638acView commit details
Commits on Jun 4, 2024
-
Use keyword args (too many args)
Co-authored-by: Erik Johnston <erikj@element.io>
Configuration menu - View commit details
-
Copy full SHA for cc35e42 - Browse repository at this point
Copy the full SHA cc35e42View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.