Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to macOS 13 runners to fix building of wheels for macOS #17321

Closed
wants to merge 3 commits into from
Closed

Switch to macOS 13 runners to fix building of wheels for macOS #17321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
210e11e
CI: Switch to macOS 13 runners
sandhose Jun 18, 2024
d826726
TEMP: build all wheels on PRs for testing
sandhose Jun 18, 2024
37a60a3
Update cibuildwheel 2.16.2 -> 2.19.1
sandhose Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions .github/workflows/release-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,35 +102,31 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04, macos-11]
os: [ubuntu-20.04, macos-13]
arch: [x86_64, aarch64]
# is_pr is a flag used to exclude certain jobs from the matrix on PRs.
# It is not read by the rest of the workflow.
is_pr:
- ${{ startsWith(github.ref, 'refs/pull/') }}

exclude:
# Don't build macos wheels on PR CI.
- is_pr: true
os: "macos-11"
# TEMP: build all wheels for testing
## Don't build macos wheels on PR CI.
#- is_pr: true
# os: "macos-13"
# Don't build aarch64 wheels on mac.
- os: "macos-11"
arch: aarch64
# Don't build aarch64 wheels on PR CI.
- is_pr: true
- os: "macos-13"
arch: aarch64
# TEMP: build all wheels for testing
## Don't build aarch64 wheels on PR CI.
#- is_pr: true
# arch: aarch64

steps:
- uses: actions/checkout@v4

- uses: actions/setup-python@v5
with:
# setup-python@v4 doesn't impose a default python version. Need to use 3.x
# here, because `python` on osx points to Python 2.7.
python-version: "3.x"

- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.16.2
run: python -m pip install cibuildwheel==2.19.1

- name: Set up QEMU to emulate aarch64
if: matrix.arch == 'aarch64'
Expand All @@ -142,9 +138,10 @@ jobs:
if: matrix.arch == 'aarch64'
run: echo 'CIBW_ARCHS_LINUX=aarch64' >> $GITHUB_ENV

- name: Only build a single wheel on PR
if: startsWith(github.ref, 'refs/pull/')
run: echo "CIBW_BUILD="cp38-manylinux_${{ matrix.arch }}"" >> $GITHUB_ENV
# TEMP: build all wheels for testing
#- name: Only build a single wheel on PR
# if: startsWith(github.ref, 'refs/pull/')
# run: echo "CIBW_BUILD="cp38-manylinux_${{ matrix.arch }}"" >> $GITHUB_ENV

- name: Build wheels
run: python -m cibuildwheel --output-dir wheelhouse
Expand Down
1 change: 1 addition & 0 deletions changelog.d/17321.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Switch to macOS 13 runners to fix building of wheels for macOS.
Loading