Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track complement release branch when releasing #17396

Closed
wants to merge 2 commits into from

Conversation

devonh
Copy link
Member

@devonh devonh commented Jul 4, 2024

I would like to test this out the next time I do a Synapse release before marking this PR as ready.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@sandhose
Copy link
Member

sandhose commented Jul 4, 2024

Oh I did that in #17318 but forgot to merge after the tick 🥲

@devonh
Copy link
Member Author

devonh commented Jul 5, 2024

Oh I did that in #17318 but forgot to merge after the tick 🥲

Ah! well that would do it. You should merge your PR & I will close this one :)

@devonh devonh closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants