Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Alpine Linux Synapse Package Maintainer within installation.md #17846

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Update Alpine Linux Synapse Package Maintainer within installation.md #17846

merged 2 commits into from
Dec 10, 2024

Conversation

jahway603
Copy link
Contributor

Update Alpine Linux Synapse Package Maintainer within installation.md as it is outdated.

Pull Request Checklist

  • Pull request is based on the develop branch
  • [N/A] Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@jahway603
Update Alpine Linux Synapse Package Maintainer within installation.md
613bf99 
Update Alpine Linux Synapse Package Maintainer within installation.md as it is outdated.
@jahway603 jahway603 requested a review from a team as a code owner October 17, 2024 19:37
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot deployed to PR Documentation Preview October 17, 2024 19:39 Active
MadLittleMods
MadLittleMods reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahway603 This is just waiting on the CLA being signed

docs/setup/installation.md
@@ -157,7 +157,7 @@ sudo pip install py-bcrypt

#### Alpine Linux

6543 maintains [Synapse packages for Alpine Linux](https://pkgs.alpinelinux.org/packages?name=synapse&branch=edge) in the community repository. Install with:
Jahway603 maintains [Synapse packages for Alpine Linux](https://pkgs.alpinelinux.org/packages?name=synapse&branch=edge) in the community repository. Install with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm this, https://pkgs.alpinelinux.org/packages?name=synapse&branch=edge indicates that jahway603 is a maintainer

MadLittleMods
MadLittleMods reviewed Oct 28, 2024
View reviewed changes
docs/setup/installation.md
@@ -157,7 +157,7 @@ sudo pip install py-bcrypt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a changelog, we can just create 17846.doc

Update maintainer of Alpine Linux Synapse package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahway603 Can you add this?

@jahway603
Copy link
Contributor Author

@jahway603 This is just waiting on the CLA being signed

I've signed the CLA before in this PR #17140

@MadLittleMods
Copy link
Contributor

@jahway603 This is just waiting on the CLA being signed

I've signed the CLA before in this PR #17140

hmm, you seem to be right as far as I can tell (same email in the patch for this PR and the one you linked). When I click "recheck" it doesn't seem to do anything.

@devonh (maintainer ping) any idea?

@devonh
Copy link
Member

devonh commented Nov 5, 2024

@jahway603 This is just waiting on the CLA being signed

I've signed the CLA before in this PR #17140

hmm, you seem to be right as far as I can tell (same email in the patch for this PR and the one you linked). When I click "recheck" it doesn't seem to do anything.

@devonh (maintainer ping) any idea?

It looks like the CLA was updated to v2.0 on October 10, 2024.
@jahway603 you will need to sign the latest version of the CLA.

@jahway603
Copy link
Contributor Author

@devonh how do I do that "safely"? I remember I was able to not dox myself on GitHub last time I signed the CLA in PR #17140.

@jahway603 jahway603 mentioned this pull request Nov 30, 2024
Closed
@jahway603
Copy link
Contributor Author

This PR relates to Issue #17977.

@devonh
Copy link
Member

devonh commented Dec 4, 2024

@devonh how do I do that "safely"? I remember I was able to not dox myself on GitHub last time I signed the CLA in PR #17140.

Following the link from the CLA Assistant above is "safe".
The information provided isn't public and is private to Element.

@devonh
Copy link
Member

devonh commented Dec 5, 2024

Looks like CI is failing due to a missing changelog entry.
Could you add changelog.d/17846.misc with something like Update Alpine Linux Synapse Package Maintainer.?

@github-actions github-actions bot deployed to PR Documentation Preview December 10, 2024 21:06 Active
@devonh
Copy link
Member

devonh commented Dec 10, 2024

Thanks for jumping through all the hoops and getting this changed :)

@devonh devonh merged commit 5da7081 into element-hq:develop Dec 10, 2024
33 checks passed
@jahway603
Copy link
Contributor Author

Fixes Issue #17977

yingziwu added a commit to yingziwu/synapse that referenced this pull request Jan 16, 2025
@yingziwu
Merge tag 'v1.122.0' into develop
4bba1ea 
Please note that this version of Synapse drops support for PostgreSQL 11 and 12. The minimum version of PostgreSQL supported is now version 13.

No significant changes since 1.122.0rc1.

- Remove support for PostgreSQL 11 and 12. Contributed by @clokep. ([\#18034](element-hq/synapse#18034))

- Added the `email.tlsname` config option.  This allows specifying the domain name used to validate the SMTP server's TLS certificate separately from the `email.smtp_host` to connect to. ([\#17849](element-hq/synapse#17849))
- Module developers will have access to the user ID of the requester when adding `check_username_for_spam` callbacks to `spam_checker_module_callbacks`. Contributed by Wilson@Pangea.chat. ([\#17916](element-hq/synapse#17916))
- Add endpoints to the Admin API to fetch the number of invites the provided user has sent after a given timestamp,
  fetch the number of rooms the provided user has joined after a given timestamp, and get report IDs of event
  reports against a provided user (i.e. where the user was the sender of the reported event). ([\#17948](element-hq/synapse#17948))
- Support stable account suspension from [MSC3823](matrix-org/matrix-spec-proposals#3823). ([\#17964](element-hq/synapse#17964))
- Add `macaroon_secret_key_path` config option. ([\#17983](element-hq/synapse#17983))

- Fix bug when rejecting withdrew invite with a `third_party_rules` module, where the invite would be stuck for the client. ([\#17930](element-hq/synapse#17930))
- Properly purge state groups tables when purging a room with the Admin API. ([\#18024](element-hq/synapse#18024))
- Fix a bug preventing the admin redaction endpoint from working on messages from remote users. ([\#18029](element-hq/synapse#18029), [\#18043](element-hq/synapse#18043))

- Update `synapse.app.generic_worker` documentation to only recommend `GET` requests for stream writer routes by default, unless the worker is also configured as a stream writer. Contributed by @evoL. ([\#17954](element-hq/synapse#17954))
- Add documentation for the previously-undocumented `last_seen_ts` query parameter to the query user Admin API. ([\#17976](element-hq/synapse#17976))
- Improve documentation for the `TaskScheduler` class. ([\#17992](element-hq/synapse#17992))
- Fix example in reverse proxy docs to include server port. ([\#17994](element-hq/synapse#17994))
- Update Alpine Linux Synapse Package Maintainer within the installation instructions. ([\#17846](element-hq/synapse#17846))

- Add `RoomID` & `EventID` rust types. ([\#17996](element-hq/synapse#17996))
- Fix various type errors across the codebase. ([\#17998](element-hq/synapse#17998))
- Disable DB statement timeout when doing a room purge since it can be quite long. ([\#18017](element-hq/synapse#18017))
- Remove some remaining uses of `twisted.internet.defer.returnValue`. Contributed by Colin Watson. ([\#18020](element-hq/synapse#18020))
- Refactor `get_profile` to no longer include fields with a value of `None`. ([\#18063](element-hq/synapse#18063))

* Bump anyhow from 1.0.93 to 1.0.95. ([\#18012](element-hq/synapse#18012), [\#18045](element-hq/synapse#18045))
* Bump authlib from 1.3.2 to 1.4.0. ([\#18048](element-hq/synapse#18048))
* Bump dawidd6/action-download-artifact from 6 to 7. ([\#17981](element-hq/synapse#17981))
* Bump http from 1.1.0 to 1.2.0. ([\#18013](element-hq/synapse#18013))
- Bump mypy from 1.11.2 to 1.12.1. ([\#17999](element-hq/synapse#17999))
* Bump mypy-zope from 1.0.8 to 1.0.9. ([\#18047](element-hq/synapse#18047))
* Bump pillow from 10.4.0 to 11.0.0. ([\#18015](element-hq/synapse#18015))
* Bump pydantic from 2.9.2 to 2.10.3. ([\#18014](element-hq/synapse#18014))
* Bump pyicu from 2.13.1 to 2.14. ([\#18060](element-hq/synapse#18060))
* Bump pyo3 from 0.23.2 to 0.23.3. ([\#18001](element-hq/synapse#18001))
* Bump python-multipart from 0.0.16 to 0.0.18. ([\#17985](element-hq/synapse#17985))
* Bump sentry-sdk from 2.17.0 to 2.19.2. ([\#18061](element-hq/synapse#18061))
* Bump serde from 1.0.215 to 1.0.217. ([\#18031](element-hq/synapse#18031), [\#18059](element-hq/synapse#18059))
* Bump serde_json from 1.0.133 to 1.0.134. ([\#18044](element-hq/synapse#18044))
* Bump twine from 5.1.1 to 6.0.1. ([\#18049](element-hq/synapse#18049))

**Changelogs for older versions can be found [here](docs/changelogs/).**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods left review comments

@devonh devonh devonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jahway603 @CLAassistant @MadLittleMods @devonh