-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of internal header encoding API #17894
Merged
MadLittleMods
merged 7 commits into
develop
from
madlittlemods/remove-usage-of-internal-header-encoding-api
Nov 4, 2024
Merged
Remove usage of internal header encoding API #17894
MadLittleMods
merged 7 commits into
develop
from
madlittlemods/remove-usage-of-internal-header-encoding-api
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
changed the title
Remove usage on internal header encoding API
Remove usage of internal header encoding API
Nov 1, 2024
erikjohnston
reviewed
Nov 4, 2024
erikjohnston
reviewed
Nov 4, 2024
erikjohnston
approved these changes
Nov 4, 2024
MadLittleMods
deleted the
madlittlemods/remove-usage-of-internal-header-encoding-api
branch
November 4, 2024 18:20
Thanks for the review @erikjohnston 🐦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of internal header encoding API.
Spawning from wanting to upgrade Twisted which no longer has these API's.
Introduced in matrix-org/synapse#15913 <- matrix-org/synapse#15773
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)