Don't build free-threaded wheels #19140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/handle_free_threaded_abi
branch
from
c3a2b85 to
43d79c6
Compare
anoadragon453
changed the title
anoadragon453
force-pushed
the
anoa/handle_free_threaded_abi
branch
from
43d79c6 to
2524deb
Compare
Member
Author
|
https://github.com/element-hq/synapse/actions/runs/19077397985/job/54496679127?pr=19140 passed, which was the goal of this PR. |
This reverts commit beb022d.
anoadragon453
force-pushed
the
anoa/handle_free_threaded_abi
branch
from
5e4fcaa to
7e90d52
Compare
MadLittleMods
approved these changes
Nov 4, 2025
anoadragon453
added a commit
that referenced
this pull request
Nov 7, 2025
The functional changes here: - Moving `cp39-*` to `skip` stops us from building wheels for Python 3.9, which was incorrectly done in #19119 (that PR only stopped the tests from failing in CI, but we were still building [and shipping] cpython 3.9 wheels). - Likewise moving `cp3??t-*` builds here prevent them from being created at all. #19140 only prevented testing them. Otherwise: - We don't build at all for i686 anyways, so `-musllinux_1686` could be replaced by `*i686*
anoadragon453
added a commit
that referenced
this pull request
Nov 7, 2025
The functional changes here: - Moving `cp39-*` to `skip` stops us from building wheels for Python 3.9, which was incorrectly done in #19119 (that PR only stopped the tests from failing in CI, but we were still building [and shipping] cpython 3.9 wheels). - Likewise moving `cp3??t-*` builds here prevent them from being created at all. #19140 only prevented testing them. Otherwise: - We don't build at all for i686 anyways, so `-musllinux_1686` could be replaced by `*i686*
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19139.
cibuildwheelattempts to build for Python 3.14t - a free-threaded interpreter - by default as it is released and stable. Synapse does not currently support free-threaded Python, so we disable building for it.Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.