Skip to content

Conversation

Copy link

Copilot AI commented Dec 1, 2025

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

Addresses MSC4308 discussion: the limit param should default to 100 when not specified.

The code already has this default (limit: StrictInt = 100 in synapse/types/rest/client/__init__.py), but no test explicitly verified this behavior.

Changes:

  • Added test_limit_defaults_to_100 which syncs without specifying limit and confirms all subscriptions are returned
# Sync without specifying 'limit' - should default to 100
sync_body = {
    "extensions": {EXT_NAME: {"enabled": True}},  # no limit specified
}
response_body, _ = self.do_sync(sync_body, tok=user1_tok)

# All 5 subscriptions returned (default limit 100 > 5)
self.assertEqual(len(thread_subscriptions["subscribed"][room_id]), 5)
Original prompt

This section details on the original issue you should resolve

<issue_title>MSC4308 Thread Subscriptions extension to Sliding Sync: limit request param in Sliding Sync extension should default to 100</issue_title>
<issue_description>matrix-org/matrix-spec-proposals#4308 (comment)</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

…ptions extension

Co-authored-by: reivilibre <38398653+reivilibre@users.noreply.github.com>
Copilot AI changed the title [WIP] Update default limit for Sliding Sync extension to 100 Add test to verify limit defaults to 100 for thread subscriptions extension Dec 1, 2025
Copilot AI requested a review from reivilibre December 1, 2025 18:07
Copilot finished work on behalf of reivilibre December 1, 2025 18:07
@reivilibre reivilibre closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSC4308 Thread Subscriptions extension to Sliding Sync: limit request param in Sliding Sync extension should default to 100

3 participants