Add test to verify limit defaults to 100 for thread subscriptions extension #19255
+36
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.Addresses MSC4308 discussion: the
limitparam should default to 100 when not specified.The code already has this default (
limit: StrictInt = 100insynapse/types/rest/client/__init__.py), but no test explicitly verified this behavior.Changes:
test_limit_defaults_to_100which syncs without specifyinglimitand confirms all subscriptions are returnedOriginal prompt
limitrequest param in Sliding Sync extension should default to 100 #18942💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.