Skip to content

"Save as" destroys data when trying to overwrite a file #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elementaryBot opened this issue May 4, 2017 · 3 comments
Closed

"Save as" destroys data when trying to overwrite a file #2

elementaryBot opened this issue May 4, 2017 · 3 comments
Labels
Priority: High To be addressed after any critical issues Status: In Progress
Milestone
3.0

Comments

@elementaryBot
Copy link
Contributor

To reproduce:

Create one file with "Well, then", save as test.txt, and close.
Create another file with "Hello there" and attempt to overwrite test.txt.

You will see "Well, then" in your editor, and "Hello there" has been destroyed (no backup either).

This, in combination with a resurfacing of bug #1392031, caused me to lose about an hour of work. Ouchies.

Workaround: ALWAYS use a new filename when saving.

Launchpad Details: #LP1668014 David Berg - 2017-02-26 08:01:56 +0000
@elementaryBot elementaryBot added the Priority: High To be addressed after any critical issues label May 4, 2017
@danirabbit danirabbit added this to the juno-beta1 milestone May 4, 2017
@jeremypw
Copy link
Collaborator

Should the existing file be moved to a backup (what name, where?) or or should the new file over-write the old, or should a dialog be displayed?

@Philip-Scott
Copy link
Member

Maybe this should be handled by our file dialog. To have a confirmation when trying to save over a file

@jeremypw jeremypw mentioned this issue Jun 12, 2017
Merged
@jeremypw
Copy link
Collaborator

jeremypw commented Jun 12, 2017 •
edited
Loading

The linked PR enables the confirmation dialog native to Gtk.FileChooser as well as fixing the data loss caused by a race between loading on focus-in and save as new file.

@bioglaze bioglaze mentioned this issue Jul 4, 2017
Closed
cassidyjames pushed a commit that referenced this issue Jan 16, 2018
@jackpot51
Merge pull request #2 from pop-os/symbolic-icons
1d2c2d5 
Symbolic icons
@S0llarCode S0llarCode mentioned this issue Nov 29, 2018
Closed
jeremypw added a commit that referenced this issue Jan 12, 2025
@jeremypw
Merge pull request #2 from elementary/jeremypw/sync-activeproject-sta…
e46440b 
…rtup

Jeremypw/sync activeproject startup
jeremypw added a commit that referenced this issue Jan 19, 2025
@jeremypw
Fix Sourcelist, DnD and events for Gtk4 port - stage 1 (#2)
90cd82e 
* First compilable version

* Emulate previous appearance of Plugins view

* Update ci.yml

* Update io.elementary.code.yml

* Bump glib dependency for libpeas-2

* Rename non-functional Flatpak manifest

* Sync checkbutton with plugin loaded on show

* Action when checkbox toggled

* Fix double parenting

* Sort plugins by name

* Use bind_model and factory

* Lose unused entities

* Cleanup and code style

* Fix initial appearance of preferences dialog

* Add some comments

* Lose commented out code

* Make activate and deactivate methods mandatory to implement

* Fix Flatpak build for OS8

* Fix ci.yml

* Add libgit2-glib-1.0-dev to ci.yml

* Split SourceList into one file per class

* Fix changed namespace

* Remove DnD code

* Replace Gdk.EventKey

* Use GestureClick

* Handle showing context menu

* Handle search_entry focus in

* Handle window close request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High To be addressed after any critical issues Status: In Progress
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
4 participants
@danirabbit @jeremypw @Philip-Scott @elementaryBot