Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement choose project dialog and use for new-branch action #1015

Closed
wants to merge 4 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Apr 30, 2021

Fixes #1005

Jeremy Wootten added 3 commits April 30, 2021 07:58
* NewBranchDialog remove superceded code
# Conflicts fixed in:
#	src/Dialogs/NewBranchDialog.vala
@jeremypw
Copy link
Collaborator Author

jeremypw commented May 1, 2021

ChooseProjectDialog

Maybe do not need both lines of text?

Maybe "git" should be main image with a "question" badge?

@jeremypw jeremypw marked this pull request as ready for review May 1, 2021 15:06
@jeremypw jeremypw requested a review from danirabbit May 1, 2021 15:06
@danirabbit
Copy link
Member

If we're creating a separate UI anyways, maybe we should stick this as a combobox on the headerbar to solve #991?

@jeremypw
Copy link
Collaborator Author

jeremypw commented May 4, 2021

@danrabbit OK, but there are some design questions to answer:

  • Where on the headerbar should it appear
  • Should it hide or become insensitive if no git projects are loaded - or if only one project is loaded.
  • Should it default to the first (or last) opened project if there are multiple projects but no documents opened?

@danirabbit
Copy link
Member

@jeremy:

  • My inclination would be to put it at the very start of the headerbar to imply that it effects every action in the application, including others that we may move to the headerbar
  • Yeah, probably it would make sense to hide for now if there are no projects loaded, but it would make sense to have it when only one project is loaded since it still does indicate the active project.
  • My inclination would be that we try to keep it updated with the most recently active project. Basically whatever our guess would have been before, we could do that logic here pro-actively instead of waiting until an action is taken. So I guess we would want to update that when we change the focused document?

@jeremypw
Copy link
Collaborator Author

jeremypw commented May 6, 2021

Closing in favour of #1023

@jeremypw jeremypw closed this May 6, 2021
@jeremypw jeremypw deleted the choose-project branch July 18, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Branch Dialog: offer a dropdown if focused project is unknown
2 participants