Add functionality to clone remote repository. #1548
Conversation
There was a problem hiding this comment.
If I'm cloning a repository, I'm almost always either typing the full path or going to this page and hitting the copy button:
But this form seems to expect different entries for the remote URL and repository path. Is that right? I'm not exactly sure how to fill out the form as written tbh
| repository_name_entry = new Granite.ValidatedEntry.from_regex (name_regex) { | ||
| activates_default = false | ||
| }; | ||
| repository_local_folder_entry = new Granite.ValidatedEntry.from_regex (local_folder_regex) { |
There was a problem hiding this comment.
This should use a file chooser because we need to make sure Code has access in the documents portal to this folder
|
|
||
| private class CloneEntry : Gtk.Box { | ||
| public CloneEntry (string label_text, Gtk.Widget entry) { | ||
| var label = new Gtk.Label (label_text) { |
There was a problem hiding this comment.
Need to make sure to set mnemonic_widget property so that entries are labeled for the screen reader
| repository_local_folder_entry.text = local_folder; | ||
| repository_host_uri_entry.text = "https://github.com"; | ||
| repository_user_entry.text = "elementary"; | ||
| repository_name_entry.text = ""; | ||
| repository_local_name_entry.text = ""; | ||
|
|
||
| on_is_valid_changed (); |
There was a problem hiding this comment.
This should all happen in the construct block. Only things necessary for the Object call should happen in a constructor
| repository_host_uri_entry.text = "https://github.com"; | ||
| repository_user_entry.text = "elementary"; |
There was a problem hiding this comment.
This should be placeholder text, not pre-filled text
| repository_name_entry.text = ""; | ||
| repository_local_name_entry.text = ""; |
There was a problem hiding this comment.
Text is empty by default. I'm not sure why you're setting it empty again?
| repository_host_uri_entry = new Granite.ValidatedEntry.from_regex (url_regex) { | ||
| activates_default = false | ||
| }; | ||
| repository_user_entry = new Granite.ValidatedEntry.from_regex (name_regex) { |
There was a problem hiding this comment.
can we pre-fill this from Environment? https://valadoc.org/glib-2.0/GLib.Environment.get_user_name.html
| activates_default = false | ||
| }; | ||
| repository_user_entry = new Granite.ValidatedEntry.from_regex (name_regex) { | ||
| activates_default = false |
There was a problem hiding this comment.
why are these set to activates_default = false? Usually you can activate from any part of the form in case you need to go back and make a correction
| add_button (_("Cancel"), Gtk.ResponseType.CANCEL); | ||
| primary_text = _("Create a local clone of a Git repository"); | ||
| ///TRANSLATORS "Git" is a proper name and must not be translated | ||
| secondary_text = _("The source repository and local folder must exist and be accessible"); |
There was a problem hiding this comment.
what does "be accessible" mean in this context?
|
|
||
| add_button (_("Cancel"), Gtk.ResponseType.CANCEL); | ||
| primary_text = _("Create a local clone of a Git repository"); | ||
| ///TRANSLATORS "Git" is a proper name and must not be translated |
There was a problem hiding this comment.
This comment is probably meant to be above the preceding line
| activates_default = false, | ||
| width_chars = 50 | ||
| }; | ||
| repository_local_name_entry = new Granite.ValidatedEntry.from_regex (name_regex) { |
There was a problem hiding this comment.
This should probably auto fill when the repository URL is changed
| /* | ||
| * Copyright 2025 elementary, Inc. (https://elementary.io) | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 2 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public | ||
| * License along with this program; if not, write to the | ||
| * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, | ||
| * Boston, MA 02110-1301 USA. | ||
| * | ||
| * Authored by: Jeremy Wootten <jeremywootten@gmail.com> | ||
| */ |
There was a problem hiding this comment.
For new files it would be nice to use the SPDX header:
| /* | |
| * Copyright 2025 elementary, Inc. (https://elementary.io) | |
| * | |
| * This program is free software; you can redistribute it and/or | |
| * modify it under the terms of the GNU General Public | |
| * License as published by the Free Software Foundation; either | |
| * version 2 of the License, or (at your option) any later version. | |
| * | |
| * This program is distributed in the hope that it will be useful, | |
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| * General Public License for more details. | |
| * | |
| * You should have received a copy of the GNU General Public | |
| * License along with this program; if not, write to the | |
| * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, | |
| * Boston, MA 02110-1301 USA. | |
| * | |
| * Authored by: Jeremy Wootten <jeremywootten@gmail.com> | |
| */ | |
| /* | |
| * SPDX-License-Identifier: GPL-2.0-or-later | |
| * SPDX-FileCopyrightText: 2025 elementary, Inc. <https://elementary.io> | |
| * | |
| * Authored by: Jeremy Wootten <jeremywootten@gmail.com> | |
| */ |
| primary_text = _("Create a local clone of a Git repository"); | ||
| ///TRANSLATORS "Git" is a proper name and must not be translated | ||
| secondary_text = _("The source repository and local folder must exist and be accessible"); | ||
| badge_icon = new ThemedIcon ("download"); |
There was a problem hiding this comment.
This is not an icon name that exists. You could do:
browser-download
or emblem-downloads. I would probably do this one, personally
| secondary_text = _("The source repository and local folder must exist and be accessible"); | ||
| badge_icon = new ThemedIcon ("download"); | ||
|
|
||
| repository_host_uri_entry = new Granite.ValidatedEntry.from_regex (url_regex) { |
There was a problem hiding this comment.
It would be nice to set input_purpose for virtual keyboards:
| repository_host_uri_entry = new Granite.ValidatedEntry.from_regex (url_regex) { | |
| repository_host_uri_entry = new Granite.ValidatedEntry.from_regex (url_regex) { | |
| input_purpose = URL, |
| }; | ||
| repository_local_folder_entry = new Granite.ValidatedEntry.from_regex (local_folder_regex) { | ||
| activates_default = false, | ||
| width_chars = 50 |
There was a problem hiding this comment.
What's the reason for adding width_chars here?
| var clone_button = new Gtk.Button.from_icon_name ("folder-open-symbolic", Gtk.IconSize.SMALL_TOOLBAR) { | ||
| action_name = Scratch.MainWindow.ACTION_PREFIX + Scratch.MainWindow.ACTION_CLONE_REPO, | ||
| always_show_image = true, | ||
| label = _("Clone …"), |
There was a problem hiding this comment.
No space before ellipsis
| label = _("Clone …"), | |
| label = _("Clone…"), |
|
|
||
| var clone_button = new Gtk.Button.from_icon_name ("folder-open-symbolic", Gtk.IconSize.SMALL_TOOLBAR) { | ||
| action_name = Scratch.MainWindow.ACTION_PREFIX + Scratch.MainWindow.ACTION_CLONE_REPO, | ||
| always_show_image = true, |
There was a problem hiding this comment.
probably shouldn't construct new image buttons in this way since you can't do this in GTK4. You have to put an image and a label in a box and pack that
| @@ -60,7 +60,16 @@ public class Code.Sidebar : Gtk.Grid { | |||
| action_name = Scratch.MainWindow.ACTION_PREFIX + Scratch.MainWindow.ACTION_OPEN_FOLDER, | |||
| action_target = new Variant.string (""), | |||
| always_show_image = true, | |||
| label = _("Open Folder…") | |||
| label = _("Open …"), | |||
There was a problem hiding this comment.
No space before ellipsis
| label = _("Open …"), | |
| label = _("Open…"), |
| xalign = 0.0f | ||
| }; | ||
|
|
||
| var clone_button = new Gtk.Button.from_icon_name ("folder-open-symbolic", Gtk.IconSize.SMALL_TOOLBAR) { |
There was a problem hiding this comment.
What do you think about making these model buttons at the end of the project selection popover?
|
@danirabbit Thanks for the detailed review! I'll get working on your comments. Regarding the dialog, I was trying to reduce the amount of typing required to specify the remote URL especially if you are cloning an elementary repository. I too usually copy paste the URL from github because I use the terminal command |
By default pulls requested named repo from "https://github.com/elementary" and clones into a repo of the same name in the parent of the current project.
Optionally makes it the active project after cloning.
The functionality is exposed in the actionbar at the bottom of the sidebar. To avoid forcing the sidebar too wide, the text is shortened and the buttons are put in a FlowBox similar to the search bar.
Suggestions for alternatives welcome.