Add inline toolbar to sidebar

[cassidyjames]

Adds an inline toolbar to the sidebar with an open folder button.

Fixes #554
Fixes #656

• Probably move toolbar to the project pane so it animates along with the stack switch
• Symbolic icons Fix sidebar inline-toolbar icon style stylesheet#563
• Better icon for "Remove folder"? No "remove folder" action for now

[jeremypw]

The simple folder icon does not really indicate its purpose - need to see tooltip. Any reason not to use the usual + and - icons?

[cassidyjames]

@jeremypw my reasoning was to use a semantic icon for explicitly opening a folder, instead of a generic "add" icon—especially since the contents of the sidebar are mixed (and not just folders).

I also worry about a "minus" icon being construed as "delete" a folder, instead of just removing it from the project view. I think for removing in that case, a context menu still might be best since the concept of which project folder is focused is also harder to see at a glance, and it might appear to be acting on a selected file instead.

[jeremypw]

I do not think the minus icon is likely to be construed as actual deletion in the context of a sidebar as it does not mean this anywhere else (I think). I agree that special "folder-add" and "folder-remove" icons, with tooltips, would be preferable. The icons should only be sensitive when a folder is selected.

[roymckenzie]

Was a bit curious about this. It seems it duplicates functionality in the HeaderBar? Is this to help de-clutter the HeaderBar?

[cassidyjames]

@roymckenzie the idea was to declutter the header bar a bit, to more clearly associate the folder/project actions with the sidebar, and to support further actions like in #568. I'm not sure if it's more discoverable or not, but I do like being able to add more folder management options there quite a bit—and those actions would feel awkward on their own.

[roymckenzie]

@cassidyjames OK cool. That makes sense. I think an "Add File" button might be cool, too. And a "Collapse All Folders" button. My only complaint is that the toolbar looks so floaty and lonely down there with just the one button and so thin. Almost anemic. Maybe with more buttons it will look better?

[cassidyjames]

@roymckenzie yeah with just one icon it's kind of silly. But I imagine both an add/remove on the left, then perhaps a gear with a submenu for things like sorting/collapsing folders on the right.

[jeremypw]

Does the job and looks good.