Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyTrashJob: rewrite without dialog.run #2248

Merged
merged 7 commits into from
Feb 4, 2024
Merged

EmptyTrashJob: rewrite without dialog.run #2248

merged 7 commits into from
Feb 4, 2024

Conversation

danirabbit
Copy link
Member

Use dialog.present and dialog.response.connect instead of dialog.run

jeremypw
jeremypw reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR no longer shows the confirmation dialog when pressing "Empty the Trash" in the Trash view - presumably because the confirm_trash () function has been removed. Was this the intention?

@danirabbit
Copy link
Member Author

Ah nope. thanks for noticing that. Will fix

jeremypw
jeremypw approved these changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second view I think it is OK to remove that extra confirmation dialog. A confirmation dialog is already potentially shown when needed (Preferences.get_default ().confirm_trash is true)

@jeremypw jeremypw merged commit 639b71e into main Feb 4, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/emptytrashjob-dialogpresent branch February 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw