Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crash] Check tab created before expand miller view #2332

Merged
merged 3 commits into from
Oct 16, 2023
Merged

[Crash] Check tab created before expand miller view #2332

merged 3 commits into from
Oct 16, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Oct 8, 2023 •
edited
Loading

Fixes #2330 (see #2330 (comment))

  • Do not attempt to expand miller view unless adding tab succeeds

Adds several extra checks to ensure that expand_miller_view is only called with valid parameters.

The issue can be reproduced by attempting to restore a disconnected location into a Column View.

@jeremypw jeremypw mentioned this pull request Oct 9, 2023
Closed
@jeremypw jeremypw marked this pull request as ready for review October 9, 2023 15:27
@jeremypw jeremypw changed the title Check tab created before expand miller view [Crash] Check tab created before expand miller view Oct 9, 2023
@jeremypw jeremypw added the Priority: High Significantly affecting majority of users' normal work label Oct 9, 2023
@jeremypw jeremypw requested a review from a team October 13, 2023 16:49
meisenzahl
meisenzahl approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@meisenzahl meisenzahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work @jeremypw

@meisenzahl meisenzahl merged commit cb4d5ac into main Oct 16, 2023
4 checks passed
@meisenzahl meisenzahl deleted the improve-restore-miller branch October 16, 2023 15:52
@jeremypw
Copy link
Collaborator Author

Thanks for your great work @jeremypw

Thanks for your reviews - they are just as important 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisenzahl meisenzahl meisenzahl approved these changes

Assignees
No one assigned
Labels
Priority: High Significantly affecting majority of users' normal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Crash] Files does not open if restoring disconnected location into Column View
2 participants
@jeremypw @meisenzahl