Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix dragging file items #2417

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Regression: Fix dragging file items #2417

merged 1 commit into from
Mar 6, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Mar 6, 2024

Dragging file items recently stopped working - this fixes that.

@jeremypw jeremypw mentioned this pull request Mar 6, 2024
@jeremypw jeremypw requested a review from a team March 6, 2024 17:28
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue! nice work

@danirabbit danirabbit merged commit 41ef82c into main Mar 6, 2024
1 of 4 checks passed
@danirabbit danirabbit deleted the jeremypw/fix-dnd branch March 6, 2024 17:39
@jeremypw
Copy link
Collaborator Author

jeremypw commented Mar 6, 2024

CI failing due to a change introduced by #2307 although it passed at the time?? Insufficient glib version.

@danirabbit
Copy link
Member

Yeah something funny there, but not the fault of this branch so overridden

@tintou
Copy link
Member

tintou commented Mar 6, 2024

The Vala version got updated and there is now a wrapper that appeared in 2.80 https://gitlab.gnome.org/GNOME/vala/-/commit/b70fa33879920fafc0534185b26ddae9e4692363#57e74b48268c28082f1bde11c4443b08145c568d_566_574

@jeremypw
Copy link
Collaborator Author

jeremypw commented Mar 7, 2024

Is any fix required in Files? It will go away in elementary 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants