Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lose unused actions in AbstractDirectoryView; simplify #2462

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Aug 28, 2024

Showing local and remote thumbnails is no longer controlled by the AbstractDirectoryView context menu so the related actions are no longer needed.

Do not need separate functions for local and remote icons - use one flag to indicate whether to show thumbnails

Extracted from #2340

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice simplification and thumbnails seem to still react to pref changes here. Nice work!

@danirabbit danirabbit merged commit 9c41d78 into main Aug 28, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/improve-thumbnail-actions branch August 28, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants