Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer elementary sound theme over freedesktop #2515

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

vjr
Copy link
Member

@vjr vjr commented Nov 28, 2024

Address elementary/triage#98

Preemptive PR so that Files plays the trash-empty sound from the elementary sound theme instead of from freedesktop.

Currently the elementary sound theme doesn't have the sound but inherits from freedesktop so there's no change in the sound, until one is added.

@vjr vjr self-assigned this Nov 28, 2024
@vjr vjr requested review from a team November 28, 2024 15:35
@vjr vjr added Priority: Wishlist Desirable new features Needs Design Waiting for input from the UX team Bitesize Simple, small diff labels Nov 28, 2024
@vjr vjr requested a review from jeremypw November 28, 2024 15:43
@vjr vjr merged commit 0ebb95a into main Nov 29, 2024
4 checks passed
@vjr vjr deleted the default-empty-trash-sound branch November 29, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bitesize Simple, small diff Needs Design Waiting for input from the UX team Priority: Wishlist Desirable new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants