-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: require mutter 42 #1496
Merged
Merged
build: require mutter 42 #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can only remove the support once elementary Odin is out |
It looks like Gala already can't really be released on OS 6, so I think it's okay to drop support for anything before horus/jammy |
bobby285271
force-pushed
the
require-mutter-42
branch
from
January 6, 2023 01:22
a7ee898
to
5304408
Compare
bobby285271
force-pushed
the
require-mutter-42
branch
from
February 15, 2023 13:47
5304408
to
fc9980a
Compare
This is a trivial change that (hopefully) shouldn't change any behavior. We want to clean up the code base with script but the script does not take care of `elif` blocks yet, luckily we don't have many `elif` blocks so we simply take care of them before we run the script.
Changes are generated by scripts except meson.build See the related pull request for more info
Changes are generated by scripts except meson.build See the related pull request for more info
Changes are generated by scripts except meson.build See the related pull request for more info
Changes are generated by scripts except meson.build See the related pull request for more info
Since we require mutter 42, (hopefully) these files are no longer needed. Note that this also removes mutter-cogl.vapi, which is already not needed when bumping mutter requirement to 3.36.
bobby285271
force-pushed
the
require-mutter-42
branch
from
February 20, 2023 06:13
964fda6
to
5a09b33
Compare
lenemter
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll merge this since OS 7 is out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick look at launchpad gala is kept on 6.3.1 in elementary OS 6.1,
not sure if we want to do this nowokay it looks like we want to do this afterOdinHorus is out but anyway here is an attempt to remove support for mutter 3.36, 3.38, 40, 41.It is unclear to me how this is done previously, here is the script I used, so for the 2nd, 3rd, 4th, 5th commits, if you spot any issues (except the manually updated meson.build), it is likely an issue of my script :-)
Use it like this
./a.out HAS_MUTTER42 <file_location>
The "vapi: Remove unused files" commit is done in a manual way, you may notice that this PR has 1000+ lines of additions, this is likely because
vapi/mutter-cogl-10.vapi
is updated from a symbolic link to an actual file (and the old "actual file"vapi/mutter-cogl-6.vapi
is removed). But anyway feel free to request changes or force push this PR if you spot random things are messed up.This also includes an removal of the
vapi/mutter-cogl.vapi
file, I guess that is probably for even older (< 3.36) mutter? 🤔Compiles against 42 and 43 and briefly tested both.