Gestures: Replace passing with_gesture with GestureTracker.recognizing #2229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we pass a
bool with_gesture
everywhere we use gesture animations for both one to one gestures and for other animations. However with some adjustment to the recognizing timing we can replace this by just checking whether the gesturetracker we're using is recognizing.This also introduces a has_started that will only turn true once on_begin was emitted to still allow for the original function of recognizing (preventing other input while the gesture is going).
This is preparation for using the shellclients panel hiding instead of the multitasking views own stuff.