Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gestures: Replace passing with_gesture with GestureTracker.recognizing #2229

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jan 15, 2025

Currently we pass a bool with_gesture everywhere we use gesture animations for both one to one gestures and for other animations. However with some adjustment to the recognizing timing we can replace this by just checking whether the gesturetracker we're using is recognizing.

This also introduces a has_started that will only turn true once on_begin was emitted to still allow for the original function of recognizing (preventing other input while the gesture is going).

This is preparation for using the shellclients panel hiding instead of the multitasking views own stuff.

@leolost2605 leolost2605 requested a review from a team January 15, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants