-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast: add dismiss signal with dismissal reason #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor query otherwise looks good.
Note that adding a parameter to the "close" signal is an API break (meaning that all the code using it will break without being recompiled) |
Yeah, in this case, it may be better to add a new signal ( |
Added a new signal |
Always send the
closed
signal when Toasts are closed manually or automatically, except when the default action is triggered. Also, add a close reason in case we want to respond differently based on whether we closed manually, expired, or withdrawn.Not sure if we need the close reason actually. afaict nothing is connecting to this signal anywhere. The motivation for this PR is that Desktop settings was watching for the toast revealer to be closed elementary/switchboard-plug-pantheon-shell@c031ada. Happy to exclude that if it seems unnecessary