SwitchModelButton: make switch not focusable #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Makes sense
However one thing I noticed it that the menuitem doesn't get highlighted when navigating via keyboard, maybe because of #707?
But since that's not related to this PR approve :)
|
@leolost2605 Granite's style sheet does have focus styles for model items, but io.elementary.stylesheet doesn't, so unless you switch to the Granite stylesheet in inspector you won't notice it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button itself is already keyboard focusable so we don't need the switch to separately be keyboard focusable. This makes keyboard navigation faster