Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeaderLabel: wrap title, halign FILL #715

Merged
merged 4 commits into from
May 1, 2024

Conversation

danirabbit
Copy link
Member

Having this set to halign = START by default ends up with us overriding this in a bunch of places. All other widgets default to FILL

wrap the title while we're here

@danirabbit danirabbit requested a review from a team April 1, 2024 17:19
@danirabbit danirabbit mentioned this pull request Apr 30, 2024
3 tasks
@ryonakano
Copy link
Contributor

Maybe we need to update the documentation comment here?

/**
 * HeaderLabel is a start-aligned {@link Gtk.Label} with the Granite H4 style class
 */
public class Granite.HeaderLabel : Gtk.Widget {

@danirabbit
Copy link
Member Author

@ryonakano updated! The label itself is still start aligned so I left that bit in

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't check everywhere we use HeaderLabel, but at least it works as expected in my Reco app (I set max_width_chars to 50 for example here):

Screenshot from 2024-05-02 08-48-05

@danirabbit danirabbit merged commit 3299cda into main May 1, 2024
5 checks passed
@danirabbit danirabbit deleted the danirabbit/headerlabel-fillandwrap branch May 1, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants