Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init: Make sure to use documentation comment #718

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Init: Make sure to use documentation comment #718

merged 1 commit into from
Apr 29, 2024

Conversation

ryonakano
Copy link
Contributor

Fixes #717

There should be no similarities in the granite source. These are almost the copyright headers:

[ryo@lb760m ~/work/tmp/granite (init-doc)]$ git grepn "\/\*" | grep -v "\/\*\*"
grep: warning: stray \ before /
1:demo/GraniteDemo.vala:1:/*
2:demo/Views/AccelLabelView.vala:1:/*
3:demo/Views/ApplicationView.vala:1:/*
4:demo/Views/CSSView.vala:1:/*
5:demo/Views/DateTimePickerView.vala:1:/*
6:demo/Views/DialogsView.vala:1:/*
7:demo/Views/FormView.vala:1:/*
8:demo/Views/HyperTextViewGrid.vala:1:/*
9:demo/Views/ModeButtonView.vala:1:/*
10:demo/Views/OverlayBarView.vala:1:/*
11:demo/Views/OverlayBarView.vala:10:        /* This is necessary to workaround an issue in the stylesheet with buttons packed directly into overlays */
12:demo/Views/SettingsUrisView.vala:1:/*
13:demo/Views/SettingsView/SettingsPage.vala:1:/*
14:demo/Views/SettingsView/SettingsView.vala:1:/*
15:demo/Views/SettingsView/SimpleSettingsPage.vala:1:/*
16:demo/Views/ToastView.vala:1:/*
17:demo/Views/UtilsView.vala:1:/*
18:demo/Views/WelcomeView.vala:1:/*
19:Binary file doc/images/AboutDialog.png matches
20:Binary file doc/images/Welcome.png matches
21:lib/Config.vala.in:1:/*
22:lib/Constants.vala:1:/*
73:lib/DateTime.vala:1:/*
81:lib/Init.vala:1:/*
83:lib/Services/Application.vala:1:/*
89:lib/Services/AsyncMutex.vala:1:/*
90:lib/Services/ContractorProxy.vala:1:/*
106:lib/Services/Portal.vala:1:/*
107:lib/Services/Settings.vala:1:/*
111:lib/Services/System.vala:1:/*
114:lib/Widgets/AbstractSettingsPage.vala:1:/*
123:lib/Widgets/AbstractSimpleSettingsPage.vala:1:/*
131:lib/Widgets/AccelLabel.vala:1:/*
138:lib/Widgets/DatePicker.vala:1:/*
144:lib/Widgets/Dialog.vala:1:/*
148:lib/Widgets/HeaderLabel.vala:1:/*
154:lib/Widgets/HyperTextView.vala:1:/*
156:lib/Widgets/HyperTextView.vala:167:        /*
157:lib/Widgets/MessageDialog.vala:1:/*
175:lib/Widgets/ModeSwitch.vala:1:/*
186:lib/Widgets/OverlayBar.vala:1:/*
192:lib/Widgets/Placeholder.vala:1:/*
199:lib/Widgets/Settings.vala:1:/*-
206:lib/Widgets/SettingsSidebar.vala:1:/*
211:lib/Widgets/SettingsSidebarRow.vala:1:/*
212:lib/Widgets/SwitchModelButton.vala:1:/*
216:lib/Widgets/TimePicker.vala:1:/*
223:lib/Widgets/Toast.vala:1:/*-
232:lib/Widgets/Utils.vala:1:/*
239:lib/Widgets/ValidatedEntry.vala:1:/*
[ryo@lb760m ~/work/tmp/granite (init-doc)]$

@danirabbit danirabbit merged commit 1291d27 into main Apr 29, 2024
5 checks passed
@danirabbit danirabbit deleted the init-doc branch April 29, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Granite.init() don't have any documentation in Valadoc
2 participants