Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init: set accent color from portal feedback #722

Merged

Conversation

ryonakano
Copy link
Contributor

@ryonakano ryonakano commented Jun 16, 2024

Review feedback for #704

I personally think this would even better for readability, but it's fine to close or modify :)

  • Keep the update_color method just parses Variant into string representation of color
    • This also makes sure that accent_color is only set in the setup_accent_color method
  • Use warning for error message
  • Set the fallback color in the catch statement instead of returning the try statement

@ryonakano ryonakano requested a review from danirabbit June 16, 2024 03:48
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes and I agree is better. Thank you!

@danirabbit danirabbit merged commit feaad3f into danirabbit/styles-accent Jun 16, 2024
3 of 5 checks passed
@danirabbit danirabbit deleted the ryonakano/styles-accent-feedback branch June 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants