Main: don't start settings daemon in installer session #761
Conversation
|
I tested this branch by creating a hock to install the greeter .deb while building the iso, but unfortunately this does not fix elementary/installer#775 😢
|
|
@ryonakano hm okay. Still probably shouldn't be starting GSD twice here. I also moved in a bit about settings the session name which affects gsettings overrides |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@ryonakano did that fix translations though?? Or is this because you logged in to demo session to install it? |
|
@danirabbit Unfortunately the translation issue still presents. I booted from the ISO built using this branch and it looks like this:
|
|
@ryonakano Wallpaper issue should be fixed by elementary/installer#840 |
|
Built a daily ISO with this branch and confirmed the wallpaper issue has been resolved. @danirabbit This PR looks good to me, but what is the difference with #768? |
|
@ryonakano that other PR was just me testing. It can be closed |
In an installer session, settings daemon is started by the session manager. Should also fix gsettings overrides not working (for example for network notifications)