Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places: New design for folder icons #1311

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

newhoa
Copy link
Collaborator

@newhoa newhoa commented Sep 17, 2024

Combines the newer design of the system-file-manager app icon with the color palette of the current folder icons. Also adjusts the aspect ratio to make it slightly wider, so it is not quite as square as system-file-manager but not quite as wide as the current folder icons.

Closes #1305


This is what has been done as of the initial PR:

  • Basic folder at all sizes
  • XDG User Directories at 48px and 64px
  • folder-open (drag-accept) at 48px

My initial thoughts/questions:

1) I am thinking the 16px folder should be slightly less rounded? (went ahead and adjusted this)
2) I just added folder-open at 48px, feedback for that one would be appreciated before I start on any other sizes.
4) Is the aspect ratio of folder okay? (personally, I am liking it a lot the more I use them so I hope that can stick).

Any feedback would be appreciated!

Thanks!

Use the new rounded folder style from the
`system-file-manager` app icon for folders.
Add base `folder` icon at missing sizes

Clean up borders of existing folders.
Fix inconsistent aspect ratio between sizes.
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are so good! I especially like how much more open the folder-open is here. It looks like it has a lot more dimension to it. Great job

Proportions of everything looks good, and I noticed these fit the baseline better compared to other icons which is really great.

Honestly these are really lovely and they do look way more modern which is great. I just had a few little nitpicks, so I opened a branch I figured that would be easier than trying to type it out: newhoa#1

@newhoa newhoa marked this pull request as ready for review October 27, 2024 12:23
@newhoa
Copy link
Collaborator Author

newhoa commented Oct 27, 2024

Okay, I think these are ready for review!

Went ahead and adjusted the shadows, gradients, and highlights for all sizes as suggested by @danirabbit here. Added folder-open remaining sizes, did the XDG emblemed folders, etc.

Let me know if anything needs adjusting!

Thanks!

@teamcons
Copy link

teamcons commented Nov 9, 2024

Okay, I think these are ready for review!

Went ahead and adjusted the shadows, gradients, and highlights for all sizes as suggested by @danirabbit here. Added folder-open remaining sizes, did the XDG emblemed folders, etc.

Let me know if anything needs adjusting!

Thanks!

I am using it on our daily computer
A nitpick would be the Files manager icon, too high

Bildschirmfoto von 2024-11-09 12 24 32

Various parts of the interface have icons with the old pointy folder. But it may be just my eyes

Bildschirmfoto von 2024-11-09 12 29 17

Each commit you do makes your hairs shinier and softer

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newhoa these look awesome! Do you think we could also do actions:

  • document-save-as
  • folder-copy
  • folder-move
  • folder-new

It looks like the inside of the folder highlight gradient stop needs to be adjusted at 24px in folder/folder-open

I think we discussed before having a different aspect ratio between folder icons in Files and the Files app icon itself is okay.

@newhoa
Copy link
Collaborator Author

newhoa commented Dec 6, 2024

@newhoa these look awesome! Do you think we could also do actions:

* [ ]  document-save-as

* [ ]  folder-copy

* [ ]  folder-move

* [ ]  folder-new

Should I make another PR for the action icons since they're a different category?

Either way, I'm wondering if the folder-open at 24px should be a simple rectangle (like it is at 16px, and like folder-open is currently at 24px) instead of using a v-shape. Or maybe a more rectangular version for the action icons only? The v-shape seems to make it loose its sharpness, and I think the sharper look is nicer for action icons at these small sizes at least.

current

prop1

Anyway, let me know if you want these added in this PR or to start another PR for the action icons.

@newhoa
Copy link
Collaborator Author

newhoa commented Dec 7, 2024

Here are alts, with the rectangle and sharper lines. This is a little more like the current look, just with the rounded folder.

Prop A:
propA

Prop B:
propB

Personally I like B here, it looks closest to what elementary currently uses, just with the rounded folder. I think it looks sharpest and cleanest.


Alt alts that I don't like so much, a different folder for open and save as:

Prop B+A:
propAB

Prop B+A2:
propAB2

Prop C (B+v-shape):
propC

@teamcons
Copy link

teamcons commented Dec 7, 2024

Id go with B.

the arrow in front of the folder, like it points to something on the ground in front of it
feels very jarring for the purpose of it. It doesnt represent "in" the folder, just "oops miss the folder go in front"

It feels like it requires rework, outside of the round folder thing

@danirabbit
Copy link
Member

@newhoa

Should I make another PR for the action icons since they're a different category?

I think it makes sense to merge them all at once 🤷‍♀️

Personally I like B here

I'm happy with that!

Thanks so much for working on these :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICON - FOLDER - Standardize folder icons
4 participants